2 Commits

Author SHA1 Message Date
615b8467ef fix(review): observation dept_manager button gate + appreciation status guard
Two issues from the whole-branch review:

1. (Important) Observation detail's can_respond_to_department context var
   did not include is_department_manager, so even though Task 2 let dept
   managers pass the view's permission check, the 'Submit Response'
   button stayed hidden from them. Now the context var matches the view
   predicate. Regression test added.

2. (Minor) appreciation_list had no guard against now-invalid status
   query params (?status=acknowledged from an old bookmark would show
   an unexplained empty list). Unknown values are now silently reset
   to 'all statuses'.
2026-07-20 22:38:12 +03:00
2829308bef fix(observation): dept_manager of assigned dept can now respond
Matches the complaint predicate. Previously a department manager could
respond to a complaint sent to their dept but not to an observation.
2026-07-20 21:50:12 +03:00