marwan/HH
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: 3 API endpoint bugs found in comprehensive API sweep
All checks were successful
Build and Push Docker Image / build (push) Successful in 2m5s
Details

Browse Source 
1. /organizations/api/organizations/ 500 — OrganizationSerializer referenced
   non-existent fields (website, license_number, logo). Removed, added
   preferred_language. Now returns 200 with correct data.

2. /journeys/api/stage-templates/ 500 — DRF auto-filter (DjangoFilterBackend)
   tried to create filters for serializer computed fields (survey_template_name).
   Added filter_backends=[] to disable auto-generation. Now returns 200.

3. /journeys/api/stage-instances/ 500 — same DRF filter issue + stale
   select_related referencing non-existent FKs (physician, survey_instance).
   Added filter_backends=[] + explicit select_related on valid FKs.
   NOTE: still crashes the dev server (segfault during DRF request chain).
   The queryset evaluates correctly in Python but the HTTP server dies.
   This is a minor read-only API endpoint; the journey UI pages all work.
   Needs further investigation of the DRF request middleware chain.
This commit is contained in:
ismail 2026-06-20 02:23:14 +03:00
parent a19ffbf320
commit 5e4926d98e
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
apps/journeys/views.py
View File

@ -69,6 +69,7 @@ class PatientJourneyStageTemplateViewSet(viewsets.ModelViewSet):
""" """
queryset = PatientJourneyStageTemplate.objects.all() queryset = PatientJourneyStageTemplate.objects.all()
serializer_class = PatientJourneyStageTemplateSerializer serializer_class = PatientJourneyStageTemplateSerializer
filter_backends = [] # disable django-filter auto-generation (serializer has computed fields)
permission_classes = [IsAuthenticated, IsPXAdminOrHospitalAdmin] permission_classes = [IsAuthenticated, IsPXAdminOrHospitalAdmin]
filterset_fields = ['journey_template', 'is_active', 'auto_send_survey'] filterset_fields = ['journey_template', 'is_active', 'auto_send_survey']
search_fields = ['name', 'name_ar', 'code', 'trigger_event_code'] search_fields = ['name', 'name_ar', 'code', 'trigger_event_code']
@ -208,8 +209,11 @@ class PatientJourneyStageInstanceViewSet(viewsets.ReadOnlyModelViewSet):
Stage instances are created automatically and updated via event processing. Stage instances are created automatically and updated via event processing.
Manual updates should be done through the admin interface. Manual updates should be done through the admin interface.
""" """
queryset = PatientJourneyStageInstance.objects.all() queryset = PatientJourneyStageInstance.objects.select_related(
"journey_instance", "stage_template", "staff", "department"
)
serializer_class = PatientJourneyStageInstanceSerializer serializer_class = PatientJourneyStageInstanceSerializer
filter_backends = [] # disable django-filter auto-generation (serializer has computed fields)
permission_classes = [IsAuthenticated] permission_classes = [IsAuthenticated]
filterset_fields = ['journey_instance', 'stage_template', 'status'] filterset_fields = ['journey_instance', 'stage_template', 'status']
search_fields = ['journey_instance__encounter_id', 'stage_template__name'] search_fields = ['journey_instance__encounter_id', 'stage_template__name']

4
apps/organizations/serializers.py
View File

@ -37,10 +37,8 @@ class OrganizationSerializer(serializers.ModelSerializer):
"city", "city",
"phone", "phone",
"email", "email",
"website", "preferred_language",
"status", "status",
"license_number",
"logo",
"hospitals_count", "hospitals_count",
"created_at", "created_at",
"updated_at", "updated_at",